Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage #318

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Update usage #318

merged 4 commits into from
Aug 19, 2024

Conversation

fellen31
Copy link
Collaborator

@fellen31 fellen31 commented Aug 13, 2024

Gives a person an honest chance at running the pipeline now that more of files are required.

Adds a parameters.md containing descriptions of all parameters. This file is autogenerated with nf-core schema docs > docs/parameters.md, but prettier messes up the formatting of the tables, so I ignore linting and editorconfig of this file.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@fellen31 fellen31 force-pushed the update-usage branch 3 times, most recently from d23a129 to 4e990b9 Compare August 15, 2024 14:14
Copy link

github-actions bot commented Aug 15, 2024

nf-core lint overall result: Passed ✅

Posted for pipeline commit cb367cb

+| ✅ 168 tests passed       |+
#| ❔  20 tests were ignored |#

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: assets/nf-core-nallo_logo_light.png
  • files_exist - File is ignored: docs/README.md
  • files_exist - File is ignored: docs/images/nf-core-nallo_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-nallo_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: conf/modules.config
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: assets/nf-core-nallo_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-nallo_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-nallo_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore
  • modules_config - modules_config

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-08-15 14:40:28

@fellen31 fellen31 marked this pull request as ready for review August 15, 2024 14:23
@fellen31 fellen31 requested a review from a team as a code owner August 15, 2024 14:23
@fellen31
Copy link
Collaborator Author

fellen31 commented Aug 15, 2024

If the changes required by the reviewer are minor (spelling, wording etc.), maybe someone else could accept those changes and merge this, and open the release PR for review :)

Copy link
Contributor

@Lucpen Lucpen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jemten jemten merged commit 83f346c into genomic-medicine-sweden:dev Aug 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants