Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple authoritative sources #151

Open
skalee opened this issue Jan 6, 2021 · 9 comments
Open

Support multiple authoritative sources #151

skalee opened this issue Jan 6, 2021 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@skalee
Copy link
Contributor

skalee commented Jan 6, 2021

Authoritative source may be composed of multiple items (e.g. in some IEV concepts), and this needs to be supported. From glossarist/iev-data#74:

skalee:

Since this pull request authoritative_source became an array. Bug or intended? If the latter, it will require corresponding changes in sites too. The failing spec is because of this change.

For example 112-01-01 fra before:

  authoritative_source:
    ref: ISO/IEC Guide 99:2007
    clause: 1.1, modifié – Suppression de NOTE 3 et NOTE 4, et quelques modifications
      dans les autres.
    link: https://www.iso.org/standard/45324.html

and now (note a leading dash in 2nd LOC):

  authoritative_source:
  - ref: ISO/IEC Guide 99:2007
    clause: '1.1'
    link: https://www.iso.org/standard/45324.html
    relationship:
      :type: :modified
      :modification: Suppression de NOTE 3 et NOTE 4, et quelques modifications dans
        les autres.
    original: ISO/IEC Guide 99:2007, 1.1, modifié – Suppression de NOTE 3 et NOTE
      4, et quelques modifications dans les autres.

ronaldtse:

This is intended because the SOURCE field apparently has multiple sources listed, and we need to separate them one by one.

@skalee skalee added the enhancement New feature or request label Jan 6, 2021
@skalee skalee self-assigned this Jan 6, 2021
@skalee
Copy link
Contributor Author

skalee commented Feb 17, 2021

@ronaldtse How to present:

  1. Multiple authoritative sources at concept level (green)?
  2. Multiple authoritative sources at localized concept level (blue)?

Should I separate them with comma, semicolon, or maybe simply double the "SOURCE" word or do something else?

Zrzut ekranu 2021-02-17 o 11 24 05

@skalee
Copy link
Contributor Author

skalee commented Feb 26, 2021

Side note: multiple source happens to English and French localized concepts only, at least for now.

@ronaldtse
Copy link
Member

This is a great question. Maybe have the multiple sources as a list under "SOURCE"? I feel that multiple instances of the word "SOURCE" will be confusing

@skalee
Copy link
Contributor Author

skalee commented Feb 26, 2021

IMO vertical list for green box, horizontal comma-separated or semicolon-separated list for blue.

@ronaldtse ronaldtse moved this to 🆕 New in Geolexica Jul 24, 2022
@ronaldtse ronaldtse moved this from 🆕 New to 📋 Backlog in Geolexica Jul 24, 2022
@strogonoff
Copy link
Contributor

@HassanAkbar if we already support multiple authoritative sources, then this issue can probably be closed!

@HassanAkbar
Copy link
Member

  1. Multiple authoritative sources at concept level (green)?

@strogonoff Currently we are showing the first authoritative source from the eng language of the concept, and in the glossarist model there is no option to set sources at concept level.
So I'm not sure if we should close this yet.

@ronaldtse
Copy link
Member

@HassanAkbar then can we ensure:

  1. Glossarist model supports sources (multiple) at the localized concept level
  2. Glossarist model supports sources (multiple) at the concept level
  3. Update the Geolexica gem to display those sources

@HassanAkbar
Copy link
Member

@ronaldtse

  1. Glossarist model supports sources (multiple) at the localized concept level

Yes

  1. Glossarist model supports sources (multiple) at the concept level

No, currently glossarist model does not support sources at concept level.

  1. Update the Geolexica gem to display those sources

geolexica/jekyll-geolexica#14
Here is the ticket for updating Jekyll-geolexica gem to use glossarist model. Waiting for the implementation of glossarist model v2 before implementing this.

@ronaldtse
Copy link
Member

No, currently glossarist model does not support sources at concept level.

Can you please help implement this?

Here is the ticket for updating Jekyll-geolexica gem to use glossarist model. Waiting for the implementation of glossarist model v2 before implementing this.

Yes let's do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Backlog
Development

No branches or pull requests

4 participants