Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken language codes #16

Open
skalee opened this issue Jul 1, 2020 · 15 comments
Open

Broken language codes #16

skalee opened this issue Jul 1, 2020 · 15 comments
Assignees
@strogonoff
Labels
bug Something isn't working

Comments

@skalee
Copy link
Contributor

skalee commented Jul 1, 2020

Some languages are broken after migration.

  • The correct ISO code is zho, but this repo uses chi.
  • The correct ISO code is nld, but this repo uses dut.
  • The correct ISO code is deu, but this repo uses ger.

They have been fixed in Excel recently (as in geolexica/isotc211.geolexica.org#110).
@skalee skalee added the bug Something isn't working label Jul 1, 2020
@ronaldtse
Copy link
Member

Maybe this is related to Glossarist? Ping @strogonoff

@ronaldtse
Copy link
Member

@strogonoff will update this in the Glossarist Desktop.

@strogonoff
Copy link
Contributor

@ronaldtse Can we change IEV to match the codes?

@strogonoff
Copy link
Contributor

Unassigning myself as codes in Glossarist Desktop is a separate concern (glossarist/glossarist-desktop#49)

@strogonoff strogonoff removed their assignment Jul 3, 2020
@ronaldtse
Copy link
Member

@ronaldtse Can we change IEV to match the codes?

Yes!

@skalee
Copy link
Contributor Author

skalee commented Jul 4, 2020 •
edited
Loading

Do you mean that you want to replace valid ISO 639-2 codes used in IEV with invalid ones used in TC211 glossary? Doesn't sound like a good idea. I can adapt though.

@ronaldtse
Copy link
Member

I meant we should change everything to the correct codes.

@strogonoff
Copy link
Contributor

invalid ones used in TC211 glossary

I thought ISO/TC 211 glossary uses correct language codes as of geolexica/isotc211.geolexica.org#110 🤔

@skalee
Copy link
Contributor Author

skalee commented Jul 6, 2020

They have been fixed in spreadsheets recently (geolexica/isotc211.geolexica.org#110 indeed), but these changes were somehow reverted at data migration.

@strogonoff strogonoff self-assigned this Jul 6, 2020
@strogonoff
Copy link
Contributor

strogonoff commented Jul 6, 2020 •
edited
Loading

Ah was that because Glossarist Desktop was still using the wrong language codes at the time of migration? Sorry if that.

Now that the app was updated to use the correct codes, let me run another migration against my fork of this repo. I expect the diff should be much smaller, since YAML is going to be dumped using the same formatting. I’ll check if that’s the case and will make a PR.

The other way to fix this would be to run a Ruby script to migrate YAML. If anyone is on to that already, please do let me know and re-assign to yourself (then I won’t do language migration in the app)

@ronaldtse
Copy link
Member

I think a global regex replace would be super easy...?

@skalee
Copy link
Contributor Author

skalee commented Jul 7, 2020

I can do a pull request.

@skalee
Copy link
Contributor Author

skalee commented Jul 7, 2020 •
edited
Loading

Wow, I'm confused. It looks like this repo already uses corrected codes, both in tc211-termbase.meta.yaml and in concepts. Also removing my temporary fixes which I did in TC 211 site does not break anything.

For sure there were no fixes in recent days. I don't know, maybe I was working on some broken branch of the glossary or something…

skalee added a commit to geolexica/isotc211.geolexica.org that referenced this issue Jul 8, 2020
@skalee
Delete unneeded fixes for the underlying data
4330488 
Language codes in data are fixed.  No more need for preprocessing them
on site generation.

See: geolexica/isotc211-glossary#16
@skalee skalee mentioned this issue Jul 8, 2020
Merged
skalee added a commit to geolexica/isotc211.geolexica.org that referenced this issue Jul 8, 2020
@skalee
Delete unneeded fixes for the underlying data (#145)
eb6c032 
Language codes in data are fixed.  No more need for preprocessing them
on site generation.

See: geolexica/isotc211-glossary#16
@strogonoff
Copy link
Contributor

Oh right, indeed. @skalee Could you confirm there are no leftover wrong language codes on some concepts? This should be doable with a grep or a Ruby script, I suppose…

@skalee
Copy link
Contributor Author

skalee commented Jul 9, 2020 •
edited
Loading

Yes @strogonoff, I confirm that there are no broken codes in concepts/concept-*.yaml nor in tc211-termbase.meta.yaml nor in register.yaml nor in change-requests/*. I suppose this issue should be closed now. Thank you!

@ronaldtse ronaldtse moved this to 🆕 New in Geolexica Jul 24, 2022
@ronaldtse ronaldtse moved this from 🆕 New to 📋 Backlog in Geolexica Jul 24, 2022
@strogonoff strogonoff mentioned this issue Apr 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@strogonoff strogonoff

Labels
bug Something isn't working
Projects
Geolexica
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ronaldtse @skalee @strogonoff