Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate LineString::coords and LineString::coords_mut? #755

Open
callpraths opened this issue Mar 2, 2022 · 0 comments
Open

Deprecate LineString::coords and LineString::coords_mut? #755

callpraths opened this issue Mar 2, 2022 · 0 comments

Comments

@callpraths
Copy link
Contributor

Related: #706 #708

None of the other geo-types have equivalent methods. There are alternatives in geo::algorithms that are more uniformly implemented:

  • LineString::coords: Alternative is CoordsIter::coords_iter (although that returns an iterator that copies the individual coordinates rather than returning a reference; If necessary, we could add a version of CoordsIter::coords_iter that returns references.
  • LineString::coords_mut: Closest alternative is MapCoordsInplace::map_coords_inplace. If we think we still need mutable iterators, that's another one we could add to CoordsIter uniformly for all types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant