Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CO2 weekly scale factors entry in GCHP ExtData.rc for carbon simulation #2684

Merged

Conversation

lizziel
Copy link
Contributor

@lizziel lizziel commented Jan 15, 2025

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Describe the update

This PR fixes a bug in the GCHP carbon simulation where the CO2 weekly scale factors were incorrectly updated only once. The update changes the time refresh in ExtData.rc to update daily.

This PR also updates the changelog to add a new section for 14.5.2.

Expected changes

CO2 weekly scale factors will be correctly applied. This causes minor differences.

Reference(s)

None

Related Github Issue

closes geoschem/GCHP#429

@lizziel lizziel requested a review from yantosca January 15, 2025 16:43
@lizziel lizziel added this to the 14.5.2 milestone Jan 15, 2025
@yantosca yantosca self-assigned this Jan 15, 2025
@yantosca yantosca added topic: GCHP Related to GCHP only topic: Configuration Files Related to GEOS-Chem configuration files category: Bug Fix Fixes a previously-reported bug no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations labels Jan 15, 2025
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lizziel. Good to merge!

@yantosca yantosca changed the base branch from main to dev/no-diff-to-benchmark January 17, 2025 19:02
@yantosca yantosca merged commit a3e623f into dev/no-diff-to-benchmark Jan 17, 2025
@msulprizio msulprizio deleted the bugfix/gchp_co2_weekly_scale_factors branch January 23, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Fix Fixes a previously-reported bug no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: Configuration Files Related to GEOS-Chem configuration files topic: GCHP Related to GCHP only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requested sample not found in file
2 participants