Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RnPbBe budget table benchmark code assumes initial restart is run resolution #318

Open
lizziel opened this issue Apr 30, 2024 · 2 comments
Assignees
Labels
category: Bug Something isn't working never stale Never label this issue as stale topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output
Milestone

Comments

@lizziel
Copy link
Contributor

lizziel commented Apr 30, 2024

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Description of your issue or question

I am generating benchmark tables comparing GC-Classic 4x5 with GC-Classic 2x2.5. It fails in the RnPbBe budget table code because it retrieves area and tropopause level from the State_Met collection which is at the model run grid resolution. The 2x2.5 run, however, uses a 4x5 initial restart file.

I am working on a fix for this and will submit a PR soon.

@lizziel lizziel added the category: Bug Something isn't working label Apr 30, 2024
@lizziel lizziel self-assigned this Apr 30, 2024
@yantosca yantosca added the topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output label Apr 30, 2024
@yantosca yantosca added this to the 1.5.0 milestone Apr 30, 2024
@lizziel
Copy link
Contributor Author

lizziel commented Apr 30, 2024

Note that this is not an issue for GCHP because GCHP initial restarts are required to be on the grid at which the model will be run.

@yantosca yantosca modified the milestones: 1.5.0, 1.6.0 May 29, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the issue from closing this issue.

@github-actions github-actions bot added the stale No recent activity on this issue label Sep 24, 2024
@lizziel lizziel added never stale Never label this issue as stale and removed stale No recent activity on this issue labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Something isn't working never stale Never label this issue as stale topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output
Projects
None yet
Development

No branches or pull requests

2 participants