Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label cleanup! #4117

Open
3 tasks done
ermo opened this issue Oct 20, 2024 · 7 comments
Open
3 tasks done

Label cleanup! #4117

ermo opened this issue Oct 20, 2024 · 7 comments
Labels
Help Wanted Type: Chore Not a feature or a bug

Comments

@ermo
Copy link
Contributor

ermo commented Oct 20, 2024

  1. Are our current labels still fit for purpose?
  2. Which new labels could we potentially benefit from?

A couple of labels that immediately came to mind as I was trawling through the packages repo PRs were:

  • Blocked (when one PR is blocked by another and the issues/PRs mention each other)
  • Needs Rebase (for older issues that are otherwise good to go, but where the original submitter should be the one rebasing)
  • Performance (for updates that make something faster w/ the numbers to back it up)

Potentially related:

@ermo ermo added Type: Chore Not a feature or a bug Help Wanted labels Oct 20, 2024
@github-project-automation github-project-automation bot moved this to Triage in Solus Oct 20, 2024
@ermo ermo moved this from Triage to Needs More Info in Solus Oct 20, 2024
@malfisya
Copy link
Member

From the quick glance, the most annoying thing is how unorganized the labels are. We can group them in categories and adding it as prefix to all of them. For example, instead of Budgie we can use Edition: Budgie and so on.

@ermo
Copy link
Contributor Author

ermo commented Oct 20, 2024

From the quick glance, the most annoying thing is how unorganized the labels are. We can group them in categories and adding it as prefix to all of them. For example, instead of Budgie we can use Edition: Budgie and so on.

Fixed.

@malfisya
Copy link
Member

I am still brainstorming oh how to categorize it further. My scratchpad https://gist.github.com/malfisya/c85a3ccd919e12a2c191c7a7ec2b1bf9, probably better on hackmd but I am not good at markdown to make it remotely presentable

@silkeh
Copy link
Member

silkeh commented Oct 24, 2024

I agree with @malfisya's that it would be beneficial to split the labels in categories/scopes. Every category should have the same colour (with different brightness if that is needed, eg: priority), but we can bikeshed that later. This was also the original idea of the colors, but they could be made more explicit. Unfortunately, GitHub doesn't have scoped labels, which would make this a lot easier.

My proposal would be to have all label names be in the form {{ Scope }}: {{ Value }}, with the following:

Scope Color Values
Blocked #cc317c Upstream, PR, Other
Edition #d4c5f9 Budgie, GNOME, Plasma, Xfce, MATE
Package TBD Request, Update Request, Deprecation/Removal, Does not build
Priority keep Wishlist, Low, Normal, High
State keep Approved, Conditionally Approved, Needs Maintainer, Stale
Topic keep Platform Integration, Plumbing, Tooling, Hardware Support, Kernel, Installation
Type keep Bug, Feature, Chore, Duplicate, Security

Additional labels for Hacktoberfest and new contributors. Maybe make these the same color?

  • Good First Issue
  • hacktoberfest-accepted
  • Help Wanted

The following labels should be removed in my opinion:

  • 4.6 ISO Testing: this is what a milestone is for.
  • Rejected, Invalid: issues can be closed as 'completed' and as 'rejected', that should be used instead.
  • VirtualboxVM: reproduction steps should be in the issue description, not the labels.
  • Needs rebase: the PR states (changes requested) should be sufficient here.
  • NVIDIA: Not really used.
  • Performance: Not really used and doesn't fit in a category.
  • ISO Blocked: A comment is probably clearer for contributors.
  • Confirmed: this is what the project state is for (triage -> ready). Same could be said for 'Needs maintainer', but I'd like to keep that for visibility to contributors.

@TraceyC77
Copy link
Contributor

TraceyC77 commented Oct 28, 2024

I like Silke's list. The only changes I would suggest are:

Under "Blocked" add ISO

Replace "Topic" with "Plumbing", I think everything else can fit under that. "Topic" isn't meaningful IMO.

Under Package - Instead of "Does hot build" use "Problem" to keep the label for the Packaging Problem template. (It's used for packages that don't build, that have dependencies missing etc)

Under Type, I would recommend we consider a new label like NotABug for things that aren't a bug (and not a chore). For instance, if /issues/4141 turns out to be a network issue, it would fit in this category.

@malfisya
Copy link
Member

I have implemented most of @silkeh 's proposals. I have not added/deleted any of the tags available, so people can give more feedback. What to delete, what to add and what color fits best. Please be aware, editing labels sometimes require editing issue forms and also updating related section in help center. Cheers!

@malfisya
Copy link
Member

Updating label => Updating issue template => Updating help-center => Updating README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Type: Chore Not a feature or a bug
Projects
Status: Needs More Info
Development

No branches or pull requests

4 participants