Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vagrant configuration file for building from scratch didn't work out of the box. #5

Open
russetkoala opened this issue Aug 7, 2013 · 3 comments

Comments

@russetkoala
Copy link

Ubuntu 12.04, Vagrant 1.0.1. The prebuilt branch worked fine out of the box, but I had to do some minor surgery on the master branch to get it to work (mostly just comparing the two and trying to minimise non-essential differences).

Diff of the necessary changes:

diff --git a/Vagrantfile b/Vagrantfile
index 562e633..38a2e4e 100644
--- a/Vagrantfile
+++ b/Vagrantfile
@@ -1,7 +1,7 @@
 # -*- mode: ruby -*-
 # vi: set ft=ruby :

-Vagrant.configure("2") do |config|
+Vagrant::Config.run do |config|
   # All Vagrant configuration is done here. The most common configuration
   # options are documented and commented below. For a complete reference,
   # please see the online documentation at vagrantup.com.
@@ -9,9 +9,7 @@ Vagrant.configure("2") do |config|
   # Every Vagrant virtual environment requires a box to build off of.
   config.vm.box = "precise32"

-  config.vm.provider "virtualbox" do |v|
-    v.customize ["modifyvm", :id, "--cpus", 4, "--memory", 3700, "--ioapic", "on"]
-  end
+  config.vm.customize ["modifyvm", :id, "--cpus", 4, "--memory", 3700, "--ioapic", "on"]

   # The url from where the 'config.vm.box' box will be fetched if it
   # doesn't already exist on the user's system.
@@ -51,7 +49,7 @@ Vagrant.configure("2") do |config|
     puppet.options = "--verbose"
   end

-  config.vm.network :forwarded_port, guest: 3000, host: 3030
+  config.vm.forward_port 3000, 3030


 end
@co-dan
Copy link
Member

co-dan commented Aug 8, 2013

I think those changes were necessary to make Vagrant2 work properly (c484be5), although I am not sure. Maybe we need some compatibility layer for Vagrantfile?

@luite
Copy link
Member

luite commented Aug 12, 2013

is there a way to make it work on both? I have 1.2.7 on my laptop (OS X), but i'd really like the current ubuntu lts to work too out of the box.

@luite
Copy link
Member

luite commented Feb 28, 2014

There's a note in the docs warning about the required vagrant version now. I'd still like it to work on 1.0, but probably not going to spend time on this, since it's getting easier to build GHCJS on a regular system now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants