Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO646 header interferes with Boost.Python's logical operator definitions on Windows 10 #87

Open
dzhoshkun opened this issue Apr 12, 2019 · 2 comments
Open

ISO646 header interferes with Boost.Python's logical operator definitions on Windows 10 #87

dzhoshkun opened this issue Apr 12, 2019 · 2 comments
Labels
to investigate
Milestone
31 12 2020

Comments

@dzhoshkun
Copy link
Contributor

This seems to be a known issue:

The following does not seem to work: https://github.com/PixarAnimationStudios/OpenSubdiv/pull/817/files
@dzhoshkun
Copy link
Contributor Author

One workaround for #69 would be to refactor all new-style logical op calls to old-style ones and then to exclude the ciso646 header.

dzhoshkun added a commit that referenced this issue Apr 12, 2019
@dzhoshkun
Issue #87: activated Windows CI for current branch
d2a2185
dzhoshkun added a commit that referenced this issue Apr 12, 2019
@dzhoshkun
Issue #87 Revert "including macros header in iobservable and videofra…
490ce39 
…me files"

This reverts commit c254fc6.
dzhoshkun added a commit that referenced this issue Apr 12, 2019
@dzhoshkun
Issue #87: Revert "added justification note to ciso646 header inclusion"
df003e0 
This reverts commit 13a6f33.
dzhoshkun added a commit that referenced this issue Apr 12, 2019
@dzhoshkun
Issue #87: Revert "including ciso646 (iso646.h) header in macros.h to…
0f339a1 
… enable global inclusion"

This reverts commit 39557f6.
dzhoshkun added a commit that referenced this issue Apr 12, 2019
@dzhoshkun
Issue #87: Revert "including macros header for Windows C++11 compatib…
5ff0f93 
…ility"

This reverts commit 31e49d0.
dzhoshkun added a commit that referenced this issue Apr 12, 2019
@dzhoshkun
Issue #87: using old-style logical ops in VideoFrame class
df21695
dzhoshkun added a commit that referenced this issue Apr 12, 2019
@dzhoshkun
Issue #87: using old-style logical ops in IObservable class
42aed52
@dzhoshkun dzhoshkun mentioned this issue Apr 12, 2019
Merged
dzhoshkun added a commit that referenced this issue Apr 12, 2019
@dzhoshkun
Issue #87: using old-style logical ops in BroadcastDaemon class
35beeec
dzhoshkun added a commit that referenced this issue Apr 12, 2019
@dzhoshkun
Issue #87: using old-style logical ops in VideoSourceFactory class
a960f97
dzhoshkun added a commit that referenced this issue Apr 12, 2019
@dzhoshkun
Issue #87: using old-style logical ops in VideoSourceEpiphanSDK class
7e6c05f
dzhoshkun added a commit that referenced this issue Apr 12, 2019
@dzhoshkun
Issue #87: using old-style logical ops in RgbToBgraConverter class
3f86bce
@dzhoshkun dzhoshkun mentioned this issue Apr 12, 2019
Closed
dzhoshkun added a commit that referenced this issue Apr 15, 2019
@dzhoshkun
Issue #87: using old-style logical ops in VideoFrame class
9be0f51
dzhoshkun added a commit that referenced this issue Apr 15, 2019
@dzhoshkun
Issue #87: using old-style logical ops in IObservable class
4c88a1c
dzhoshkun added a commit that referenced this issue Apr 15, 2019
@dzhoshkun
Issue #87: using old-style logical ops in BroadcastDaemon class
d88ed5d
dzhoshkun added a commit that referenced this issue Apr 15, 2019
@dzhoshkun
Issue #87: using old-style logical ops in VideoSourceFactory class
ea8dd57
dzhoshkun added a commit that referenced this issue Apr 15, 2019
@dzhoshkun
Issue #87: using old-style logical ops in VideoSourceEpiphanSDK class
f99363c
dzhoshkun added a commit that referenced this issue Apr 16, 2019
@dzhoshkun
Issue #87: using old-style logical ops in RgbToBgraConverter class
4ae1951
@dzhoshkun
Copy link
Contributor Author

Some relevant commits that make use of the ciso646 header are in #72

dzhoshkun added a commit that referenced this issue May 2, 2019
@dzhoshkun
Issue #87, issue #104, PR #105: using old-style logical ops in VideoS…
fb6caf7 
…ourceFactory test
dzhoshkun added a commit that referenced this issue May 2, 2019
@dzhoshkun
Issue #87, issue #104, PR #105: using old-style logical ops in RGB-to…
86ab8fc 
…_BGRA profiler
dzhoshkun added a commit that referenced this issue May 2, 2019
@dzhoshkun
Issue #87, issue #104 [ci-skip]: using old-style logical ops in Video…
4bafa0c 
…SourceFactory test
dzhoshkun added a commit that referenced this issue May 2, 2019
@dzhoshkun
Issue #87, issue #104 [ci-skip]: using old-style logical ops in RGB-t…
265ce6f 
…o_BGRA profiler
@dzhoshkun dzhoshkun mentioned this issue May 2, 2019
Closed
dzhoshkun added a commit that referenced this issue May 2, 2019
@dzhoshkun
Issue #87: using old-style logical ops in VideoSourceFFmpeg class
3ee378e
dzhoshkun added a commit that referenced this issue May 2, 2019
@dzhoshkun
Issue #87: using old-style logical ops in VideoTargetFFmpeg class
06ef5db
@dzhoshkun dzhoshkun mentioned this issue May 2, 2019
Merged
dzhoshkun added a commit that referenced this issue May 2, 2019
@dzhoshkun
Merge pull request #112 from gift-surg/87-use-old-style-logical-ops-i…
a6c1c47 
…n-ffmpeg-components

Using old-style logical ops in FFmpeg components due to #87
@joubs joubs added this to the 31 12 2020 milestone Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
to investigate
Projects
None yet
Milestone
31 12 2020
Development

No branches or pull requests
2 participants
@dzhoshkun @joubs