Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ovc.Client could end up in infinite loop if a task is lost #30

Open
redlicha opened this issue Feb 24, 2020 · 1 comment
Open

ovc.Client could end up in infinite loop if a task is lost #30

redlicha opened this issue Feb 24, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@redlicha
Copy link

redlicha commented Feb 24, 2020

https://github.com/gig-tech/ovc-sdk-go/blob/v1.4.1/ovc/client.go#L208-L250 : if querying the state of a task consistently returns a "404", the loop is never exited

@redlicha redlicha added the bug Something isn't working label Feb 24, 2020
@grimpy
Copy link
Contributor

grimpy commented Feb 25, 2020

The case for 404 is wrong, there is no option of it not existing yet.
If it's 404 the task result expired (happens 10min after completion of task).

At the time @redlicha tested this though openvcloud / master had a problem it would always return 404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants