Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Thumbnail click if thumbnail is active #31

Open
jordywichgers opened this issue Oct 30, 2019 · 0 comments
Open

BUG: Thumbnail click if thumbnail is active #31

jordywichgers opened this issue Oct 30, 2019 · 0 comments

Comments

@jordywichgers
Copy link

Hi,

We really love you extensions of Owl Carousel thanks for your time and effort. Our developers found out a bug in the code which is annoying for the user experience. This is the situation:

When you click on the thumbnail that already is active (e.g. double click on the thumbnail) the last thumbnail of the carousel will become active, instead of the one you double-clicked on. The same thing happens when you click not on a specific thumbnail but inside of the owl-thumbs division. The last thumbnail of the carousel will become active instead of that nothing will happen.

This is how we adjust your code.
if ( $( e.target ).index() === 2) { //only change image if thumbnail is not active already
We apply this if statement around options.thumbsPrerendered.

Maybe you can look into this to make your library even better and more user-friendly. If there is anything we can help you with. Let me know.

All the best,
Jordy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant