-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proof of concept - Low temperature heating without modifying MHI-AC-Ctrl using only the internal temperature sensor #83
Comments
Thank you for the contribution! |
Thanks for the lovely reply! My free time is currently limited, but I'll pick this up in the future if someone else hasn't already. |
Is there a update to this so we can run this too? |
Just my 2 cents on this, but I do wonder if your readings @TerminatorNL are influenced by an offset setting on the AC. More details can be found on this issue. This can also be found in official documentation of the AC-units, although it's not always described the same way. It seems by default it corrects the temperature with 2 degrees to 'compensate' for additional heat that is caused by the location of the aircondition (high and near ceilings). You can disable this offset and make it more accurate (maybe). I imagine this setting has impact on your readings and the AC-behavior. Also, I'm not sure if your code changes are a good thing (yet) for people using an external sensor like me. It seems to cause some issues (see my comment in your PR). |
Hi Ginkage,
Thank you so much for your hard work making this ESPHome variant of the MHI AC Ctrl. I've combined your code with the latest version of absalom-muc/MHI-AC-Ctrl@c6592d3.
The approach in my fork master...TerminatorNL:MHI-AC-Ctrl-ESPHome-TempRange:master allows reading the internal temperature sensor and feeds that value back into the AC unit as external room temperature. I've had this running for a week now, and experienced no issues.
I decided to not make a PR because my code style might not line up with yours as I'm relatively new to C++ and ESPHome programming. But you are more than welcome to take inspiration (read: copy) from my approach and spread the love.
Here's some of my findings:
You can see the most important change here: https://github.com/TerminatorNL/MHI-AC-Ctrl-ESPHome-TempRange/blob/f5e0fb8a48fd069097ba1d6a01fcc0edbbac20ac/mhi_ac_ctrl.h#L145-L194
The internal temperature sensor actually updates quite quickly. I'm quite confident we could do away with an external temperature sensor all together if we just add one additional offset as a calibration parameter, but that was out of scope for me for now.
I hope this helps you and others.
The text was updated successfully, but these errors were encountered: