Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wallet connection UI on the submit page #720

Merged
merged 6 commits into from
Jan 30, 2025

Conversation

jfschwarz
Copy link
Collaborator

@jfschwarz jfschwarz commented Jan 30, 2025

part of #703

wagmi's useReconnect hook doesn't do what we assumed, and as we're already using useAutoReconnect we'll basically never need it. Instead for triggering a full wallet reconnect, we can simply pop open the connectkit modal.

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zodiac-pilot-companion-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 0:43am

Copy link

cloudflare-workers-and-pages bot commented Jan 30, 2025

Deploying zodiac-pilot-connect with  Cloudflare Pages  Cloudflare Pages

Latest commit: e967cdd
Status: ✅  Deploy successful!
Preview URL: https://ea563fb1.zodiac-pilot.pages.dev
Branch Preview URL: https://fix-submit-wallet-connect.zodiac-pilot.pages.dev

View logs

@jfschwarz jfschwarz force-pushed the fix-submit-wallet-connect branch from b7918d0 to 72d2a5a Compare January 30, 2025 11:42
Copy link

cloudflare-workers-and-pages bot commented Jan 30, 2025

Deploying zodiac-pilot with  Cloudflare Pages  Cloudflare Pages

Latest commit: e967cdd
Status: ✅  Deploy successful!
Preview URL: https://9f7cd2a0.zodiac-pilot-29m.pages.dev
Branch Preview URL: https://fix-submit-wallet-connect.zodiac-pilot-29m.pages.dev

View logs

Copy link

github-actions bot commented Jan 30, 2025

Coverage Report for deployables/extension

Status Category Percentage Covered / Total
🔵 Lines 63.48% 3276 / 5160
🔵 Statements 63.48% 3276 / 5160
🔵 Functions 70.56% 175 / 248
🔵 Branches 77.73% 412 / 530
File CoverageNo changed files found.
Generated in workflow #1538 for commit e967cdd by the Vitest Coverage Report Action

Copy link
Member

@frontendphil frontendphil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) The new LaunchConnectKit component also makes for better re-usability. I'll let you fiddle with the E2E tests now :D

@jfschwarz jfschwarz enabled auto-merge (squash) January 30, 2025 12:39
@jfschwarz jfschwarz merged commit 103f256 into main Jan 30, 2025
16 checks passed
@jfschwarz jfschwarz deleted the fix-submit-wallet-connect branch January 30, 2025 12:45
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants