Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(limit): set default limit to math.MaxInt when only offset is provided #7333

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aydinomer00
Copy link

Description

This PR fixes an issue where MySQL requires both LIMIT and OFFSET to be provided when using OFFSET. When only OFFSET is specified, the LIMIT is now automatically set to math.MaxInt.

Changes

  • Updated Limit clause to use math.MaxInt when only offset is provided
  • Updated existing tests to reflect new behavior
  • Added new test cases to verify the behavior

Related Issue

Fixes #7302

Testing

  • Added new test case for verifying behavior when only offset is provided
  • All existing tests pass
  • Manually tested with MySQL

…ided

- Ensures MySQL compatibility by always providing a LIMIT when OFFSET is used
- Updates tests to reflect new behavior
- Improves code organization and documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using only offset instead of limit
1 participant