Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you accept a PR to support the password-source: keyring config on Windows? #459

Open
bkane-msft opened this issue Apr 7, 2022 · 3 comments

Comments

@bkane-msft
Copy link

When password-source: keyring is set in my config and I run on Windows, I get the following error:

PS C:\Users\bkane> jira login
Keyring is not supported for Windows, see: https://github.com/tmc/keyring

I think this keyring support in Windows can easily be added by replacing https://github.com/tmc/keyring with https://github.com/zalando/go-keyring in the keyringGet/keyringSet code.

Would you accept a PR with this code change and updated docs? jira would be easier to use on Windows and I could share the same config between Windows and Mac :)

@georgettica
Copy link
Collaborator

I am not against it and a PR is up to replace the keyring to a newer/more updated version.
If you would like to collab/test it that might help your use case aswell

@chipbite
Copy link

It seems that PR was not accepted and merged, right?
Wanted to try this on windows, but one still cant use windows keyring, I guess?

@bkane-msft
Copy link
Author

That PR was not merged, and, two years later, I doubt that it will be. You could compile locally from the branch and run that I suppose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants