Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing files in changes.csv are reported in 18 #438

Closed
tschmidtb51 opened this issue Aug 18, 2023 · 2 comments
Closed

Missing files in changes.csv are reported in 18 #438

tschmidtb51 opened this issue Aug 18, 2023 · 2 comments
Assignees
@JanHoefelmeyer
Labels
bug Something isn't working csaf_checker

Comments

@tschmidtb51
Copy link
Collaborator

Currently (v2.2.1-95-ga65fead) missing files in the changes.csv are reported in requirement 18 instead of 13. IMHO, this is a bug.
@tschmidtb51 tschmidtb51 added bug Something isn't working csaf_checker labels Aug 18, 2023
@tschmidtb51 tschmidtb51 mentioned this issue Aug 19, 2023
Merged
@s-l-teichmann s-l-teichmann mentioned this issue Aug 22, 2023
Closed
@JanHoefelmeyer JanHoefelmeyer mentioned this issue Aug 23, 2023
Merged
@JanHoefelmeyer
Copy link
Contributor

Currently, discrepancies between found files in between the different used retrieval methods are all checked within the "CheckMissing()" method, which logs all of them in Requirement 18. While testing, I also found that an empty changes.csv only results in a warning and further checks on whether entries are missing are ignored as well.

Proper error sorting is done in #441

@JanHoefelmeyer
Copy link
Contributor

Solved via #441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JanHoefelmeyer JanHoefelmeyer

Labels
bug Something isn't working csaf_checker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tschmidtb51 @JanHoefelmeyer