-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve SHA* marking #289
Comments
I can confirm this issue. It is still appearing. |
This is in the current version ( |
At least the following cases must be covered:
For the first 4 cases, it would be nice to collapse the message to one summary, if it is true for all tested advisories. |
Shall this done as part of service+dev? Just add the label. |
Looking at the issue again, I think an additional option would be nice, where I could explicitly point out which hash should be looked for. |
I just want to inform you that this issue impacted us too. So under We get tons of:
Whereas corresponding I got the feedback from a colleague that the corresponding pull request does not fully resolve the situation (and lacks a bit of documentation on what CLI options to use). Imo @tschmidtb51 is right with his listing of cases, and it'd be great to have a way to explicitly point out which hash the checker should be looking for. |
We think it's better to report this under 15. We don't necessarily want to report one error in multiple places, and listing this under 18 gives the wrong impression that the ROLIE feed is fine which may lead to further confusion if e.g. the shas can simply not be found. |
We need to improve the error message for requirement 18, if only one hash is found: Currently, it reports the other one as missing and labels that as an error. This applies only, if the missing hash wasn't listed in the ROLIE feed.
The text was updated successfully, but these errors were encountered: