Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the Kotlin runtime library be shaded? #11

Open
barend-xebia opened this issue Dec 9, 2024 · 0 comments
Open

Should the Kotlin runtime library be shaded? #11

barend-xebia opened this issue Dec 9, 2024 · 0 comments
Milestone

Comments

@barend-xebia
Copy link
Contributor

The spot-complete package includes opentelemetry-exporter-otlp, which in turn relies on OkHttp and, through that, on Kotlin. The OkHttp and Okio libraries are shaded, because I found NoSuchMethodError during execution, indicating multiple versions on the classpath. That problem did not afflict the kotlin libraries, and they're packaged as-is.

It may be wise to shade them for the sake of it, ensuring that the spot-complete package is fully standalone.

[info]   +-io.opentelemetry:opentelemetry-exporter-otlp:1.45.0
[info]   | +-io.opentelemetry:opentelemetry-exporter-otlp-common:1.45.0
[info]   | +-io.opentelemetry:opentelemetry-exporter-sender-okhttp:1.45.0
[info]   | | +-com.squareup.okhttp3:okhttp:4.12.0
[info]   | | | +-com.squareup.okio:okio:3.6.0
[info]   | | | | +-com.squareup.okio:okio-jvm:3.6.0
[info]   | | | |   +-org.jetbrains.kotlin:kotlin-stdlib-common:1.9.10
[info]   | | | |   +-org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.10
[info]   | | | |     +-org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.9.10
[info]   | | | |     | +-org.jetbrains.kotlin:kotlin-stdlib:1.9.10
[info]   | | | |     |   +-org.jetbrains.kotlin:kotlin-stdlib-common:1.9.10
[info]   | | | |     |   +-org.jetbrains:annotations:13.0
[info]   | | | |     |
[info]   | | | |     +-org.jetbrains.kotlin:kotlin-stdlib:1.9.10
[info]   | | | |       +-org.jetbrains.kotlin:kotlin-stdlib-common:1.9.10
[info]   | | | |       +-org.jetbrains:annotations:13.0
@barend-xebia barend-xebia added this to the v1.0.0 milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant