-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Code health] Move task sequence calculation / handling into a separate handler #2958
Labels
type: code health
Improvements to readability or robustness of codebase
Comments
shobhitagarwal1612
added
the
type: code health
Improvements to readability or robustness of codebase
label
Dec 30, 2024
Proposed structure for the sequence handler:
|
@gino-m @anandwana001 Thoughts? |
abstraction looks like a good approach @shobhitagarwal1612 |
This was referenced Dec 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently,
DataCollectionViewModel
does a lot of things incl. creation of task sequence and performing various operations using the generated task sequence. This bloats up the class and reduces the code readability / maintainability.This could be handled in a better way by abstracting out all task sequence related methods into a single wrapper class. This would greatly improve the overall structure of the class.
The text was updated successfully, but these errors were encountered: