-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Code health] Rename ground
folder back to app
#1389
Comments
app sgtm |
@JSunde @shobhitagarwal1612 Are you ok with this change as well? |
Yes. This seems ok to me as well |
SIr may I help you in this ? |
Hi @Sachin-2206, thanks for offering to help! Can you kindly sign https://cla.developers.google.com/clas before proceeding? |
@gino-m I would love to handle this issue if it's free |
@gino-m Sir I want to know that I just rename the 'ground' folder name to 'app' ? |
@gino-m I just need a little help to know that what I exactly have to do in this issue. May you help me please ? |
Done |
@Sachin-2206, yes, that's correct. The path to the module will also need to be updated in relevant config files (*.gradle, *.yaml). @EmmanuelDav This issue was already assigned. Please wait for issues to be assigned to you before proceeding. Thanks! |
Ok. My apologies |
@gino-m Sir I rename ground folder name to app folder name. and I also rename the package name of all files of ground folder to app. Is it correct or should I change something else. I will send the sample or screenshot , check it and tell me as soon as possible. |
The package name does not need to change, only the module folder name at project root level. Thanks! |
Hello @Sachin-2206 , |
@devedroy Sorry for late reply, still interested in taking this one? |
@gino-m Thanks for the reply. |
Please go ahead! |
ground
folderground
folder back to app
@devedroy Let me know if you're still interested and we can reassign. |
The path
ground-android/ground
is slightly confusing, and seems to imply the level about it is not actually part ofground
.Perhaps the default
app
would be more appropriate here?@scolsen @JSunde @shobhitagarwal1612 for thoughts.
The text was updated successfully, but these errors were encountered: