Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code health] Rename ground folder back to app #1389

Closed
gino-m opened this issue Jan 3, 2023 · 18 comments · Fixed by #2989
Closed

[Code health] Rename ground folder back to app #1389

gino-m opened this issue Jan 3, 2023 · 18 comments · Fixed by #2989
Assignees
Labels
good first issue type: code health Improvements to readability or robustness of codebase
Milestone

Comments

@gino-m
Copy link
Collaborator

gino-m commented Jan 3, 2023

The path ground-android/ground is slightly confusing, and seems to imply the level about it is not actually part of ground.

Perhaps the default app would be more appropriate here?

@scolsen @JSunde @shobhitagarwal1612 for thoughts.

@gino-m gino-m added type: code health Improvements to readability or robustness of codebase priority: p2 labels Jan 3, 2023
@scolsen
Copy link
Contributor

scolsen commented Jan 3, 2023

app sgtm

@gino-m
Copy link
Collaborator Author

gino-m commented Jan 3, 2023

@JSunde @shobhitagarwal1612 Are you ok with this change as well?

@shobhitagarwal1612
Copy link
Member

Yes. This seems ok to me as well

@Sachin-2206
Copy link

SIr may I help you in this ?

@gino-m
Copy link
Collaborator Author

gino-m commented Jan 4, 2023

Hi @Sachin-2206, thanks for offering to help!

Can you kindly sign https://cla.developers.google.com/clas before proceeding?

@EmmanuelDav
Copy link
Contributor

@gino-m I would love to handle this issue if it's free

@Sachin-2206
Copy link

@gino-m Sir I want to know that I just rename the 'ground' folder name to 'app' ?

@Sachin-2206
Copy link

@gino-m I just need a little help to know that what I exactly have to do in this issue. May you help me please ?

@EmmanuelDav
Copy link
Contributor

Done

@gino-m
Copy link
Collaborator Author

gino-m commented Jan 9, 2023

@gino-m Sir I want to know that I just rename the 'ground' folder name to 'app' ?

@Sachin-2206, yes, that's correct. The path to the module will also need to be updated in relevant config files (*.gradle, *.yaml).

@EmmanuelDav This issue was already assigned. Please wait for issues to be assigned to you before proceeding. Thanks!

@EmmanuelDav
Copy link
Contributor

Ok. My apologies

@Sachin-2206
Copy link

@gino-m Sir I rename ground folder name to app folder name. and I also rename the package name of all files of ground folder to app. Is it correct or should I change something else. I will send the sample or screenshot , check it and tell me as soon as possible.
Screenshot (1)

@gino-m
Copy link
Collaborator Author

gino-m commented Jan 10, 2023

@gino-m Sir I rename ground folder name to app folder name. and I also rename the package name of all files of ground folder to app. Is it correct or should I change something else. I will send the sample or screenshot , check it and tell me as soon as possible.
Screenshot (1)

The package name does not need to change, only the module folder name at project root level. Thanks!

@devedroy
Copy link
Contributor

Hello @Sachin-2206 ,
Are you still working on this issue?
If not, I would love to take this up.
Thankyou.

@gino-m gino-m added this to Ground Dec 19, 2023
@gino-m
Copy link
Collaborator Author

gino-m commented Dec 19, 2023

@devedroy Sorry for late reply, still interested in taking this one?

@devedroy
Copy link
Contributor

@gino-m Thanks for the reply.
Yes, I would love to take up this issue.

@gino-m
Copy link
Collaborator Author

gino-m commented Dec 20, 2023

@gino-m Thanks for the reply. Yes, I would love to take up this issue.

Please go ahead!

@gino-m gino-m removed this from Ground Dec 20, 2023
@gino-m gino-m changed the title [Code health] Rename ground folder [Code health] Rename ground folder back to app Jan 15, 2024
@gino-m
Copy link
Collaborator Author

gino-m commented Apr 17, 2024

@devedroy Let me know if you're still interested and we can reassign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue type: code health Improvements to readability or robustness of codebase
Projects
Status: Done
7 participants