From 9dfd0b42ed3d4dea4119e35bdc8c8233f82be556 Mon Sep 17 00:00:00 2001 From: Eric Astor Date: Fri, 3 Jan 2025 15:22:55 -0800 Subject: [PATCH] [XLS] Enable internal FIFO materialization for several examples We currently require an external FIFO definition by default, and these targets only passed due to not requiring a definition for depth-0 FIFOs before commit 4b262b0de9775fd254dd99f14b4d2458021b8259 We're planning to land a more batteries-included solution soon. PiperOrigin-RevId: 711868494 --- xls/examples/BUILD | 1 + xls/modules/zstd/memory/BUILD | 3 +++ 2 files changed, 4 insertions(+) diff --git a/xls/examples/BUILD b/xls/examples/BUILD index fb2b953094..2bcafb8ac0 100644 --- a/xls/examples/BUILD +++ b/xls/examples/BUILD @@ -834,6 +834,7 @@ xls_ir_verilog( "streaming_channel_ready_suffix": "_ready", "streaming_channel_valid_suffix": "_valid", "use_system_verilog": "true", + "materialize_internal_fifos": "true", }, verilog_file = "delay.sv", ) diff --git a/xls/modules/zstd/memory/BUILD b/xls/modules/zstd/memory/BUILD index f1c53d78f4..ca5e0a155f 100644 --- a/xls/modules/zstd/memory/BUILD +++ b/xls/modules/zstd/memory/BUILD @@ -386,6 +386,7 @@ mem_reader_codegen_args = common_codegen_args | { "flop_inputs_kind": "skid", "flop_outputs_kind": "skid", "clock_period_ps": MEM_READER_CLOCK_PERIOD_PS, + "materialize_internal_fifos": "true", } xls_dslx_verilog( @@ -440,6 +441,7 @@ mem_reader_adv_codegen_args = common_codegen_args | { "flop_inputs_kind": "skid", "flop_outputs_kind": "skid", "clock_period_ps": MEM_READER_CLOCK_PERIOD_PS, + "materialize_internal_fifos": "true", } xls_dslx_verilog( @@ -668,6 +670,7 @@ mem_writer_codegen_args = common_codegen_args | { "flop_inputs_kind": "skid", "flop_outputs_kind": "skid", "worst_case_throughput": "1", + "materialize_internal_fifos": "true", } xls_dslx_verilog(