Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigtable: return general error on mutate rows for individual row mutations #11473

Open
andre-sampaio opened this issue Jan 20, 2025 · 0 comments
Assignees
Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@andre-sampaio
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The current ApplyBulk implementation returns (nil, err) in case of a failure in the entire operation, and ([]err, nil) in case of individual mutation failures. This is inconsistent with other client implementations (e.g. python, java (on gax)), and is also more error prone (2 different fields to check for errors vs a single source of truth).

Describe the solution you'd like

Create a new ApplyBulkV2 (or whatever the name is), use a return value of err error and aggregate individual mutations exceptions in some aggregated error type. Deprecate the existing method.

Describe alternatives you've considered

  • Changing the existing method: not viable since that would be a breaking change.
  • Keep returning (errs []error, err error) but always set the second parameter if there are any individual exceptions: seems redundant when we can aggregate the exceptions on a meaningful type.

Additional context

The way the conformance tests Test Framework is setup needs us to implement a proxy server to proxy requests for each client's implementation. We would need then to change the method we currently call on our proxy server, potentially leaving the deprecated implementation not covered by conformance tests.

To make this safer we should make sure both the new and the deprecated ApplyBulk go through the same code path, and change only how each of them returns errors.

@andre-sampaio andre-sampaio added the triage me I really want to be triaged. label Jan 20, 2025
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jan 20, 2025
@bhshkh bhshkh added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants