Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fontc producing less lookups for inline contextual liga substitutions #1132

Closed
cmyr opened this issue Nov 19, 2024 · 1 comment
Closed

fontc producing less lookups for inline contextual liga substitutions #1132

cmyr opened this issue Nov 19, 2024 · 1 comment
Labels
crater Issues based on a crater diff
Milestone

Comments

@cmyr
Copy link
Member

cmyr commented Nov 19, 2024

Given the FEA,

lookup locl_latn_1 {
        script latn;
        language CAT;
        sub l' periodcentered' l by ldot;
        sub L' periodcentered' L by Ldot;
} locl_latn_1;

(from https://github.com/googlefonts/fuggles/blob/master/sources/Fuggles.glyphs)

fontc produces a single type-4 lookup with sub L periodcentered by Ldot and sub l periodcentered by ldot, but fontmake produces a different lookup for each rule.

It would be easy enough to make fontc match fontmake, but unless I'm missing something the fontc version is better; fontmake performs this same optimization in other places, just not here.

@anthrotype would it be much work to add this in fontmake?

edit: opened fonttools/fonttools#3701 to discuss addressing this in fonttools

@cmyr cmyr added the crater Issues based on a crater diff label Nov 19, 2024
@rsheeter rsheeter added this to the fontc 1.0 milestone Jan 22, 2025
@cmyr
Copy link
Member Author

cmyr commented Feb 4, 2025

fixed this in fonttools with fonttools/fonttools#3726

@cmyr cmyr closed this as completed Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crater Issues based on a crater diff
Projects
None yet
Development

No branches or pull requests

2 participants