From 22695d9c99805ce64406607923797296c467de81 Mon Sep 17 00:00:00 2001 From: Khaled Hosny Date: Wed, 28 Aug 2024 22:28:55 +0300 Subject: [PATCH] Fix the order of feature writers We want curs feature lookups to come first, then kerning, then mark/mkmk, but we currently are calling CursFeatureWriter last which causes its lookups to be also written last. The lookup order does not matter for HarfBuzz, but it matters for other implementations, see: https://github.com/harfbuzz/harfbuzz/issues/4596#issuecomment-2220558649 --- Lib/glyphsLib/builder/constants.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/glyphsLib/builder/constants.py b/Lib/glyphsLib/builder/constants.py index 6aba4c86b..49a90c406 100644 --- a/Lib/glyphsLib/builder/constants.py +++ b/Lib/glyphsLib/builder/constants.py @@ -206,13 +206,13 @@ UFO2FT_META_TABLE_KEY = PUBLIC_PREFIX + "openTypeMeta" DEFAULT_FEATURE_WRITERS = [ + {"class": "CursFeatureWriter"}, {"class": "KernFeatureWriter"}, { "module": "glyphsLib.featureWriters.markFeatureWriter", "class": "ContextualMarkFeatureWriter", }, {"class": "GdefFeatureWriter"}, - {"class": "CursFeatureWriter"}, ] DEFAULT_LAYER_NAME = PUBLIC_PREFIX + "default"