block-builder: Add cortex_blockbuilder_blocks_produced_total metric #10538
+109
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesh Vernekar <[email protected]>
codesome
commented
Jan 29, 2025
Comment on lines
-77
to
-80
| if cfg.NoPartiallyConsumedRegion { | ||
| // We should not have a large buffer if we are putting all the records into a block. | ||
| cfg.ConsumeIntervalBuffer = 5 * time.Minute | ||
| } |
There was a problem hiding this comment.
By removing this override, we can now try different buffer times when we have set NoPartiallyConsumedRegion to true
Signed-off-by: Ganesh Vernekar <[email protected]>
narqo
reviewed
Jan 30, 2025
Comment on lines
+615
to
+618
| prev, curr, next := getBlockCategoryCount(sectionEndTime, blockMetas) | ||
| b.blockBuilderMetrics.blockCounts.WithLabelValues("previous").Add(float64(prev)) | ||
| b.blockBuilderMetrics.blockCounts.WithLabelValues("current").Add(float64(curr)) | ||
| b.blockBuilderMetrics.blockCounts.WithLabelValues("next").Add(float64(next)) |
There was a problem hiding this comment.
Have you considered putting these metrics inside TSDBBuilder.CompactAndUpload (ie. make them a part of tsdbMetrics collection). It feels this would require fewer changes in the overall code, and make "magic knowledge", like 2h block ranges, scoped closer together.
There was a problem hiding this comment.
That was my first try, but giving the information about current block end to TSDB did not look right. I am not too worried about the number of lines of change here because it's mostly replacing old stuff and only a minor addition of this function.
Signed-off-by: Ganesh Vernekar <[email protected]>
Signed-off-by: Ganesh Vernekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds a metric to determine how many blocks were produced for previous, current, and next block period w.r.t. the cycle end time.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.