Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render craft=brewery #1966

Closed
Schwitzd opened this issue Nov 9, 2015 · 15 comments
Closed

render craft=brewery #1966

Schwitzd opened this issue Nov 9, 2015 · 15 comments

Comments

@Schwitzd
Copy link

Schwitzd commented Nov 9, 2015

Dear all

Please render craft=brewery with a nice icon :)

Thanks a lot
G4rp

@HolgerJeromin
Copy link
Contributor

If you can buy a beer, it is a pub or bar.
If it is large, it is landuse industrial.
I don't think we need an icon for this...

@Schwitzd
Copy link
Author

Schwitzd commented Nov 9, 2015

are small craft brewing company, in the last years always more and more are opening, here one example: http://www.openstreetmap.org/node/3693191925

@polarbearing
Copy link
Contributor

currently 1500 uses

@matkoniecz matkoniecz added this to the New features milestone Nov 10, 2015
@matthijsmelissen
Copy link
Collaborator

I think features like these deserve to have their name rendered, but are too rare to deserve their own icon.

@kocio-pl
Copy link
Collaborator

Looks like a subset of #1697.

@matkoniecz
Copy link
Contributor

So it is for places

  • where it is impossible to buy anything (otherwise it would have pub or bar icon or at least would be tagged as shop)
  • it is impossible to visit them for tour or something similar (it would be tourism=museum/attraction)
  • are not big enough to draw even small landuse
  • are even not filling entire building (building names are rendered)

I am unsure whatever rendering name would be valuable (alcohol-related icon would be clearly misleading as it is not bar/pub/shop so it is unacceptable).

@SomeoneElseOSM
Copy link
Contributor

Why should it be "impossible to buy anything" or "impossible to visit for a tour" at a craft=brewery? In OSM I've always tried to use the most appropriate tag, even if some other more popular tag may also apply. See e.g. http://www.openstreetmap.org/way/359616375 and the adjacent pub.

@matkoniecz
Copy link
Contributor

In cases where it is possible to buy something or visit proper tagging already results in rendering. Or would it be valuable for such cases to display second label?

@matkoniecz matkoniecz modified the milestones: 3.x - Needs upgrade to Mapnik, New features Jun 9, 2016
@matkoniecz
Copy link
Contributor

As craft key is not currently in the database.

@SomeoneElseOSM
Copy link
Contributor

... "already results in rendering" indeed, but as something that isn't the best tag for an object. I'm sure that you can go on occasional brewery tours to Springhead Brewery linked above, but it's primarily a brewery rather than a tourist attraction (I certainly didn't consider it enough of a tourist attraction to tag it as such).

@dieterdreist
Copy link

sent from a phone

Il giorno 09 giu 2016, alle ore 20:26, Mateusz Konieczny [email protected] ha scritto:

So it is for places

where it is impossible to buy anything (otherwise it would have pub or bar icon or at least would be tagged as shop)

no, it is a different notion, craft is not for places, it is for people/businesses (operating at these places). It can also be added in addition to other tags like pub or factory (works)

it is impossible to visit them for tour or something similar (it would be tourism=museum/attraction)

not necessarily. Not every place that has guided visits is a museum

are not big enough to draw even small landuse

landuse is a property of the land, how it is roughly used, not a feature like a brewer making beer

are even not filling entire building (building names are rendered)

this is not about a building (see also 1st point), but about a business. These should ideally not be mixed on the same object (I know that doing it is widespread nonetheless) as they very likely have different attributes (name, start_date, wikipedia, etc.)

cheers,
Martin

@dieterdreist
Copy link

sent from a phone

Il giorno 09 giu 2016, alle ore 21:26, Mateusz Konieczny [email protected] ha scritto:

would it be valuable for such cases to display second label?

what about "different label" rather than "second"?

@nebulon42
Copy link
Contributor

I think this issue does not belong to the Mapnik upgrade milestone but rather to the Style upgrade milestone.

@pnorman pnorman modified the milestones: 3.x - Needs upgrade to openstreetmap-carto.style, 3.x - Needs upgrade to Mapnik Sep 3, 2016
@Tomasz-W
Copy link

Please close this ticket and move further discussion to #1697

@Tomasz-W
Copy link

@kocio-pl Please close this issue as duplicate of #1697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests