Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A list of possibly deprecated, but rendered tags: #204

Closed
19 tasks done
tyrasd opened this issue Sep 30, 2013 · 19 comments
Closed
19 tasks done

A list of possibly deprecated, but rendered tags: #204

tyrasd opened this issue Sep 30, 2013 · 19 comments
Labels
buildings new features Requests to render new features water

Comments

@tyrasd
Copy link
Contributor

tyrasd commented Sep 30, 2013

After reading the guidelines I've hacked together a script that searches for typos and deprecated tags in the openstreetmap-carto stylesheet. It does this by searching for key-value tag selectors in the cartocss stylesheets and cross-checking those with the taginfo databases. Tags that can't be found on neither the tables for popular tags nor the table for wiki-documented tags are filtered out.

In the end I've come up with the following list of tags that are rendered in openstreetmap-carto, but are undocumented and not used widely:

aerialways.mss

amenity-points.mss

buildings.mss

landcover.mss

placenames.mss

roads.mss

water.mss

@gravitystorm
Copy link
Owner

Awesome work

@dieterdreist
Copy link

2013/9/30 Martin Raifer [email protected]

In the end I've come up with the following list of tags that are rendered
in openstreetmap-carto, but are undocumented and not used
widely:aerialways.mss

+0.97
the only 2 that might merit reconsideration are

building=station (is this the same as building=train_station?)
waterway=lock (is this the same as waterway=lock_gate?)

both used more than 1000 times (but admittedly they seem undocumented what
makes it hard to say what they are used for, e.g. there are also
power_stations etc. and it seems better to advocate expressive tagging with
the main style).

@matthijsmelissen
Copy link
Collaborator

highway=runway
highway=taxiway

Those should be aeroway.

pnorman added a commit to pnorman/openstreetmap-carto that referenced this issue Oct 1, 2013
These tags are wrong and there are no occurances in the database.

See gravitystorm#204
@pnorman
Copy link
Collaborator

pnorman commented Oct 1, 2013

point=yes is not a tag in the stylesheet but is from a column coming from the SQL.

The MSS comes up within the selector .text where the SQL #text and #text-poly both have the class but they generate the column 'yes'::text as point and 'no'::text as point respectively. It is, as is probably obvious, a confusing way to do this.

@matkoniecz
Copy link
Contributor

natural=field rendering was removed in #617

@Zverik
Copy link
Contributor

Zverik commented Jul 4, 2014

Please do not deprecate tags that are widely used, just because someone on wiki decided on a better alternative. E.g. amenity=emergency_phone is used 7k times, emergency=phone — 27k.

@matkoniecz
Copy link
Contributor

water.mss

Two are unused and undocumented: waterway=mill_pond (used 3 times) and landuse=water (246 times + clearly replaced by natural=water). I plan on making pull request that will remove rendering for these tags.

natural=marsh is used 11 836 times, JOSM validator detects it and suggests change. Usage is to high to stop rendering it now, waiting a year or two is probably preferable.

@matthijsmelissen
Copy link
Collaborator

What is the evidence that barrier=embankment and landuse=conservation are deprecated? Both are used 1000s of times.

@matkoniecz
Copy link
Contributor

"possibly deprecated" (AKA no page on the wiki)

@matthijsmelissen
Copy link
Collaborator

Ok, I removed these two from the list.

matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Jul 28, 2014
We still render landuse=cemetery and amenity=grave_yard.

See issue gravitystorm#204.
@matthijsmelissen
Copy link
Collaborator

Removed natural=marsh, does not seem to be deprecated.

@pnorman
Copy link
Collaborator

pnorman commented Aug 12, 2014

waterway=mill_pond has two uses on ways.

pnorman added a commit to pnorman/openstreetmap-carto that referenced this issue Aug 12, 2014
This reformats the water SQL, and eliminates unused and hardly used
mistaken taggings for water.

Cross-reference gravitystorm#204
@pnorman pnorman mentioned this issue Aug 12, 2014
@matthijsmelissen
Copy link
Collaborator

landuse=graveyard has been dropped by #793.

@matthijsmelissen
Copy link
Collaborator

landuse=conservation is still in widespread use so I will remove it.

@matkoniecz
Copy link
Contributor

building=station

Wiki recommends building=train_station ( http://wiki.openstreetmap.org/wiki/Tag:building%3Dtrain_station ). What would be better - rendering both or only building=train_station?

@matkoniecz
Copy link
Contributor

amenity=emergency_phone

It is covered by #318 and requires database upgrade (I edited OP and removed it from this list)

@matkoniecz
Copy link
Contributor

waterway=lock

Undocumented, in rendering assumed to be a node (it shows lock_gate.png symbol), only 298 instances of nodes, entire usage found by Overpass that I checked is duplicated by documented tags. It also seems to be removed in #991 PR.

@matkoniecz
Copy link
Contributor

building=station is no longer considered special.

@pnorman
Copy link
Collaborator

pnorman commented May 17, 2015

all resolved.

@pnorman pnorman closed this as completed May 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buildings new features Requests to render new features water
Projects
None yet
Development

No branches or pull requests

7 participants