Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render craft= #4550

Closed
dch0ph opened this issue May 14, 2022 · 1 comment
Closed

Render craft= #4550

dch0ph opened this issue May 14, 2022 · 1 comment

Comments

@dch0ph
Copy link
Contributor

dch0ph commented May 14, 2022

The craft key is used to tag places where goods are created / skills exercised, as opposed to retail (shop=) and large factories (man_made=works). It has been used ~250k times (taginfo), compared to say shop= (over 5m), and has an extensive set of JOSM presets. Currently craft is not rendered, and so mapping areas such as industrial estates is frustrating as nothing appears and units appear vacant. But there are also high-street outlets which are currently not rendered e.g. craft=key_cutter.

There is a strong connection with shop=, e.g. craft=confectionery indicates a site where (primarily) confectionery is made, while shop=confectionery sells confectionery made elsewhere.

It would seem straightforward to extend the machinery of rendering shop to craft, distinguishing the two based on colour; shop uses purple, craft would use a visually distinct colour with the same icon, e.g. the burnt orange colour used to label landuse=farmyard.

In the absence of an icon, a coloured dot would be used in the same way as shop= or office=. This would ensure the name was rendered, which is often sufficient to indicate the nature of the business.

The craft rendering would be prioritised over shop in cases where both tags are present (the wiki suggests that both can be used where goods are both manufactured and sold). Rendering craft would encourage its use to highlight places where original items are made.

This would seem to be a relatively easy win?

@imagico
Copy link
Collaborator

imagico commented May 14, 2022

In this generic form this is a duplicate of #1697 - i am therefore going to close it as such. If you would like to suggest rendering specific craft tags, e.g. craft=confectionery please open distinct, concrete issues for that.

What we quite definitely will not want to do is introducing a catch-all rendering for any and all values of craft=*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants