Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytorch version rollover breaks some version checking logic #32

Open
lav8org opened this issue Aug 31, 2021 · 0 comments
Open

pytorch version rollover breaks some version checking logic #32

lav8org opened this issue Aug 31, 2021 · 0 comments

Comments

@lav8org
Copy link

lav8org commented Aug 31, 2021

  1. Thanks for this awesome library!
  2. Since torch doesn't report version with zero fill, lexicographical sort breaks from numerical at digit rollover (1.10). The particular instance I've just hit is line 58 of lucent/optvis/param/spatial.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lav8org