Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Different texts for Labels and legends #5

Open
yancorrea1995 opened this issue May 9, 2019 · 6 comments
Open

[Feature request] Different texts for Labels and legends #5

yancorrea1995 opened this issue May 9, 2019 · 6 comments

Comments

@yancorrea1995
Copy link

Would it be possible to add this feature?

Add a setting to set legends (subtitles) and Labels separately. One field for each object.

Thanks!

@yancorrea1995 yancorrea1995 changed the title Different texts for Labels and legends [Feature request] Different texts for Labels and legends May 9, 2019
@greghub
Copy link
Owner

greghub commented May 9, 2019

Hi @yancorrea1995 , thanks for your interest!
could you please clarify by "setting separately"?
Currently, it is possible to set labels and sub-labels (legends):

data: {
    labels: ['Impressions', 'Add To Cart', 'Buy'],
    subLabels: ['Direct', 'Social Media', 'Ads'],
    ...
}

What would be wish to set the values?

@yancorrea1995
Copy link
Author

Hi Greg!

During mouse hover, add the possibility of customizing the text, so that it is different from the legend in the bottom of funnel.
export

@yancorrea1995
Copy link
Author

And, if possible, add an option to hide the zero values in the mouse hover. Example (hide "Idea 02: 0" because the "0" is not a necessary information. That will make the Funnel more clean and easy to view.

@lordplagus02
Copy link

lordplagus02 commented May 16, 2019

Agreed with removing zeroes for usability, but having to adapt the data to remove subsets with no values made for some efficient backend code 😛

@yancorrea1995
Copy link
Author

Don't need to remove the values, just hide. Who to use chooses whether or not to hide with a flag (option) in the settings of the funnel.

@maitsa
Copy link

maitsa commented Aug 6, 2019

I made a workaround to hide empty sublabel values. The last "if" hide also results with only 1 value, to avoid redundancy with main label.

$('div.svg-funnel-js ul.segment-percentage__list').each(function (i, list) {
    list = $(list);
    var listItems = list.find('span.percentage__list-label');
    listItems.each(function (j, elem) {
        elem = $(elem);
        if (elem.text().startsWith("0")) {
            elem.closest('li').addClass('hidden');
        }
    });

    if (list.find('li:not(.hidden)').length <= 1) {
        list.closest('.label__segment-percentages').addClass('hidden');
    }        
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants