ParallelTests::Cucumber::FailuresLogger is broken

[codener]

ParallelTests::Cucumber::FailuresLogger seems to be broken, at least for parallel_tests v3.8.1 with cucumber v7.1.0 and parallel_tests v4.7.2 with cucumber v9.2.0. It brings a #done method that does the right thing, but that method is never called. Instead, on test run completion, a callback inherited from Cucumber::Formatter::Rerun is executed. Since that was not written for parallelism, it improperly joins failure locations without a space, rendering the failures log file useless.

# Broken failure log
$ cat tmp/cucumber_failures.log
features/a.feature:3features/another.feature:3

A working patch looks like this:

# Monkey patch
class ParallelTests::Cucumber::FailuresLogger

  def initialize(config)
    super
    patch_handlers(config) # <-- Added
    @io = prepare_io(config.out_stream)
  end

  def patch_handlers(config)
    # Remove handler inherited from Cucumber::Formatter::Rerun
    handlers = config.event_bus.instance_variable_get(:@handlers)
    handlers['Cucumber::Events::TestRunFinished'].pop

    config.on_event :test_run_finished do
      done
    end
  end

end

I assume, Cucumber would need an official option to either remove an event handler, or to prevent one from being added.

wdyt?

[grosser]

patch looks alright, make sure to add a test that fails without it first :)
and most of this issues description as inline comment to explain what is going on

[codener]

Ok nice. Will provide a patch, probably next year.