Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build plugin fails when two .proto files have the same name #41

Open
glbrntt opened this issue Jan 30, 2025 · 0 comments
Open

Build plugin fails when two .proto files have the same name #41

glbrntt opened this issue Jan 30, 2025 · 0 comments
Labels
kind/bug Feature doesn't work as expected. size/M Medium task. (A couple of days of work.)

Comments

@glbrntt
Copy link
Collaborator

glbrntt commented Jan 30, 2025

If two .proto files have the same name, e.g.:

  • foo/bar.proto
  • bar/bar.proto

Then the build plugin will generate files call foo/bar.grpc.swift and bar/bar.grpc.swift, when compiled these will both result in object files called bar.grpc.swift.o(the path prefix is dropped) which causes compilation to fail.

We currently pass FileNaming=FullPath to the protoc plugins, we should switch to PathToUnderscores instead.
@glbrntt glbrntt added kind/bug Feature doesn't work as expected. size/M Medium task. (A couple of days of work.) labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Feature doesn't work as expected. size/M Medium task. (A couple of days of work.)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glbrntt