Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keywords stored on Zenodo as strings instead of an array #918

Open
punkish opened this issue Oct 7, 2020 · 5 comments
Open

keywords stored on Zenodo as strings instead of an array #918

punkish opened this issue Oct 7, 2020 · 5 comments

Comments

@punkish
Copy link

punkish commented Oct 7, 2020

Looking at https://zenodo.org/api/records/4067600 the keywords field is listed as

"keywords": [
              "acorn barnacles Indonesian biodiversity new record stalked barnacles taxonomy"
 ],

Perhaps that should be an array of those words but is being stored as a long string, no?

cc @gsautter @myrmoteras @tcatapano

@gsautter
Copy link
Owner

gsautter commented Oct 7, 2020

Two things:
(a) This isn't a GG Imagine issue at all, as GGI proper doesn't even know there is a server, let alone there is something like Zenodo or how its API works ... maybe we should have a little chat about our overall system architecture at some point
(b) As https://zenodo.org/record/4067600 clearly shows (the "part of" link resolves to https://zse.pensoft.net/article/55733/ ), this is a deposition made by Pensoft (we do not upload any figures linked to from XML (TaxPub) imports), so you're barking up the wrong tree ...

@gsautter
Copy link
Owner

gsautter commented Oct 7, 2020

Email to Teodor about this is out now.

@myrmoteras
Copy link

@gsautter

a) This isn't a GG Imagine issue at all, as GGI proper doesn't even know there is a server, let alone there is something like Zenodo or how its API works ... maybe we should have a little chat about our overall system architecture at some point

this is a good point and I am supposed to ask you to get an (updated) https://drive.google.com/file/d/0B_yrQwn4yBySbk9KWkNDa0RZd0U/view?usp=sharing

@punkish
Copy link
Author

punkish commented Oct 7, 2020

Two things:
(a) This isn't a GG Imagine issue at all, as GGI proper doesn't even know there is a server

Being clueless myself, I asked @myrmoteras and he suggested I post the issue here. So, he is to blame 😉

, let alone there is something like Zenodo or how its API works ... maybe we should have a little chat about our overall system architecture at some point

Yea, that would be great. From my side, I thought that perhaps GGI is responsible for parsing the text into an array so it kinda made sense. Obviously I was wrong. Understanding the architecture (and the pipeline) would be tremendously helpful.

(b) As https://zenodo.org/record/4067600 clearly shows (the "part of" link resolves to https://zse.pensoft.net/article/55733/ ), this is a deposition made by Pensoft (we do not upload any figures linked to from XML (TaxPub) imports), so you're barking up the wrong tree ...

Well, that is way beyond my ken. I am glad you have bumped this to @teodorgeorgiev.

Also, this kind of thing could be caught with some kind of automated QC, no?

Thanks

@teodorgeorgiev
Copy link

Looking at https://zenodo.org/api/records/4067600 the keywords field is listed as

"keywords": [
              "acorn barnacles Indonesian biodiversity new record stalked barnacles taxonomy"
 ],

Perhaps that should be an array of those words but is being stored as a long string, no?

cc @gsautter @myrmoteras @tcatapano

It has been fixed

"keywords": [
"acorn barnacles",
"Indonesian biodiversity",
"new record",
"stalked barnacles",
"taxonomy"
],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants