Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG viewBox property is missing #3

Open
hbroer opened this issue Feb 27, 2020 · 0 comments
Open

SVG viewBox property is missing #3

hbroer opened this issue Feb 27, 2020 · 0 comments

Comments

@hbroer
Copy link

hbroer commented Feb 27, 2020

The viewBox property is missing on the svg element. Scaling (inline) svg results in a image which is cut off.

Line 798 qrcode/index.js

  var svg = '<?xml version="1.0" standalone="yes"?>' + '<svg xmlns="http://www.w3.org/2000/svg" version="1.1" viewBox="0 0 ' + width + ' ' + height + '" width="' + width + '" height="' + height + '">';

I may do a pull request later if needed.
madc added a commit to madc/pure-svg-code that referenced this issue Feb 21, 2022
@madc
Set viewBox instead of width/height
98967b2 
Refs gwuhaolin#3
@madc madc mentioned this issue Feb 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hbroer