Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary fence in quadrature operator #31

Open
EmilyBourne opened this issue Dec 19, 2024 · 0 comments
Open

Unnecessary fence in quadrature operator #31

EmilyBourne opened this issue Dec 19, 2024 · 0 comments

Comments

@EmilyBourne
Copy link
Member

A seemingly unnecessary fence was added in the quadrature operator in !586. This allows the code to avoid a seg fault which appears when compiling certain CPU functions using CPU quadrature with a compilation configured with KOKKOS_SERIAL=ON and KOKKOS_CUDA=ON. The seg fault only appears when compiling in Release mode.

A issue will be opened in DDC with a reproducer. When the issue has been investigated (and hopefully fixed) the fence should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant