From 6d10f5b65382291c7e7652b0b93657750e32da56 Mon Sep 17 00:00:00 2001 From: krzychus Date: Thu, 27 Jul 2023 13:43:13 +0200 Subject: [PATCH] LoggerFactory slf4j related regression fix Fix the regression that caused DRF loading fail due to spurious dependency on slf4j when log4j2 exists. Check for water logging availability was throwing exception if slf4j was not used while loading some models. this seems like a regression between 3.30 and 3.40. https://github.com/h2oai/h2o-3/issues/6725 --- h2o-logger/src/main/java/water/logging/LoggerFactory.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/h2o-logger/src/main/java/water/logging/LoggerFactory.java b/h2o-logger/src/main/java/water/logging/LoggerFactory.java index fd318ad07c8d..61d44630151a 100644 --- a/h2o-logger/src/main/java/water/logging/LoggerFactory.java +++ b/h2o-logger/src/main/java/water/logging/LoggerFactory.java @@ -78,7 +78,7 @@ private boolean isWaterLogAvailable() { try { Class.forName(waterLogClassName); return true; - } catch (ClassNotFoundException e) { + } catch (ClassNotFoundException | NoClassDefFoundError e) { return false; } }