Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update python package structure / tooling #16503

Open
5 tasks
hutch3232 opened this issue Jan 27, 2025 · 2 comments
Open
5 tasks

update python package structure / tooling #16503

hutch3232 opened this issue Jan 27, 2025 · 2 comments

Comments

@hutch3232
Copy link

Looking at the python package structure, I saw a few areas that could be modernized (for lack of a better word). I would be happy to make a PR. Would a contribution towards this be welcome?

Some ideas I had (open to others as well):

  • migrate from setup.py to pyproject.toml
  • migrate from flake8 to ruff
  • implement PEP 735 dependency groups for optional dependencies like polars and python
  • publish wheels
  • update build steps to avoid deprecated python setup.py approach
@tomasfryda
Copy link
Contributor

I agree h2o-3 packages should be modernized (both Python and R) but it's harder than it might look:

  • h2o-3 tries to support older versions (I think we still test/support R 3.5 and python 3.6 (maybe even older))
  • the tests have to run on our infrastructure and I don't think our test images are ready for the modernized version of the packages (and this would have to be done by us)

And h2o-3 team has now a lot of work (due to parental leaves and "GenAI" there is less time for people work to on h2o-3) so the team has to prioritize a lot, so I'm afraid your PR would not be merged anytime soon. (So I wouldn't recommend creating a PR towards this).

But I'm grateful that you'd like to contribute.

@hutch3232
Copy link
Author

As someone who still uses R 3.5.3 in some environments, the extended support is greatly appreciated 😀. We can come back to this at some point perhaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants