From 6737d9f08355c4fd8ef091e86ad2404314962b74 Mon Sep 17 00:00:00 2001
From: Vijitha Ekanayake <ekvijitha@gmail.com>
Date: Fri, 18 Dec 2020 16:47:03 +0530
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: mturoci <64769322+mturoci@users.noreply.github.com>
---
 ui/src/textbox.test.tsx | 4 ++--
 ui/src/textbox.tsx      | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/ui/src/textbox.test.tsx b/ui/src/textbox.test.tsx
index f9851d4292..71eb12ab68 100644
--- a/ui/src/textbox.test.tsx
+++ b/ui/src/textbox.test.tsx
@@ -112,7 +112,7 @@ describe('Textbox.tsx', () => {
     expect(syncMock).toBeCalled()
   })
 
-  it('Does not call sync on key up  - When the key is not Enter key', () => {
+  it('Does not call sync when key pressed is not enter', () => {
     const { getByTestId } = render(<XTextbox model={textboxProps} />)
     const syncMock = jest.fn()
 
@@ -122,7 +122,7 @@ describe('Textbox.tsx', () => {
     expect(syncMock).not.toBeCalled()
   })
 
-  it('Does not call sync on key up  - When multiline is true', () => {
+  it('Does not call sync on enter - multiline is true', () => {
     const { getByTestId } = render(<XTextbox model={{ ...textboxProps, multiline: true}} />)
     const syncMock = jest.fn()
 
diff --git a/ui/src/textbox.tsx b/ui/src/textbox.tsx
index 2f7bd60a4b..7d9c5644c6 100644
--- a/ui/src/textbox.tsx
+++ b/ui/src/textbox.tsx
@@ -75,9 +75,9 @@ export const
         qd.args[m.name] = v ?? (m.value || '')
         if (m.trigger) qd.sync()
       },
-      onKeyUp = ( event: React.KeyboardEvent<HTMLInputElement>, v?: string) => {
-        if ((event).key == "Enter" && event.target instanceof HTMLInputElement) {
-          v = v || (event.target as HTMLInputElement).value
+      onKeyUp = ( {key, target}: React.KeyboardEvent<HTMLInputElement>, v?: S) => {
+        if (key == 'Enter' && target instanceof HTMLInputElement) {
+          v = v || target.value
           qd.args[m.name] = v ?? (m.value || '')
           qd.sync()
         }
@@ -121,4 +121,4 @@ export const
         )
 
     return { render }
-  })
\ No newline at end of file
+  })