Fixed ships awaiting payout #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BudzioT
requested review from
malted,
maxwofford and
polytroper
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
polytroper
previously requested changes
Jan 19, 2025
There was a problem hiding this comment.
Actually can we change this to just use the paid_out bool from airtable?
Checking if there are 10 matchups is fragile. There are actually scenarios where a ship can count 10, get paid out 1, then go back one if a vote is marked as low-quality after the fact
I also don't want to proliferate the magic number 10 into more places where it will have to be tracked down later if (when...) we want to change it
malted
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier because of using adjusted_payout, payout was set to 0 instead of null, so ships awaiting payouts didn't show how many matchups are left, but just "0 doubloons".
Changed it, while making sure that ships that were hidden and didn't go through 10 matchups (so usually getting caught on fraud before payout) won't show negative matchups remaining