Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate a' during debug #110

Open
db4 opened this issue Aug 15, 2017 · 4 comments
Open

Evaluate a' during debug #110

db4 opened this issue Aug 15, 2017 · 4 comments
Milestone

Comments

@db4
Copy link
Contributor

db4 commented Aug 15, 2017

Hovering over a variable with trailing single quote (like a') does not work properly: a is evaluated instead. I suppose it's vscode debug engine passing the wrong name to evaluateRequest() but maybe it can be tuned to handle OCaml variable names correctly? initializeRequest() or something like that?

A related problem is that one cannot evaluate record fields like a.b. Besides problems with hovering engine it also requires some changes in the value parser to work even in a watch: ocamldebug responds in that case with "$<number> : <type> = <value>" where $<number> is a temporary id, not acceptable for the current parser.

@hackwaly hackwaly added this to the 0.6.x milestone Aug 16, 2017
@hackwaly
Copy link
Owner

@db4 The a' problem is that vscode doesn't use language's wordPattern to extract expression. See https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/debug/electron-browser/debugHover.ts#L139
The a.b is fixed.

hackwaly added a commit that referenced this issue Aug 16, 2017
@db4
Copy link
Contributor Author

db4 commented Aug 16, 2017

@hackwaly

The a.b is fixed.

Great, thanks a lot!

The a' problem is that vscode doesn't use language's wordPattern to extract expression.

I see. Maybe it's worth a bug report or feature request to vscode team?

@hackwaly
Copy link
Owner

hackwaly commented Aug 16, 2017

Maybe it's worth a bug report or feature request to vscode team?

Yes, it is.

@db4
Copy link
Contributor Author

db4 commented Aug 29, 2017

Alas, the vscode team won't fix microsoft/vscode#32873 in the foreseeable future. So you can close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants