Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad substitution reported by primaza.sh script when HTTP body contains: nulnulnulnul #311

Open
cmoulliard opened this issue May 4, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@cmoulliard
Copy link
Contributor

Issue

We got a bad substitution when we execute this command:

$(pwd)/scripts/primaza.sh localdeploy
$ k cp local-kind-kubeconfig primaza/primaza-app-7dcc89fbd-vn2nm:/tmp/local-kind-kubeconfig -c primaza-app
$HOME/code/halkyonio/primaza-poc/scripts/primaza.sh: line 145: warning: command substitution: ignored null byte in input
@cmoulliard cmoulliard added the bug Something isn't working label May 4, 2023
@jacobdotcosta jacobdotcosta self-assigned this May 23, 2023
@cmoulliard
Copy link
Contributor Author

Can you have a look ? @jacobdotcosta

@cmoulliard
Copy link
Contributor Author

warning: command substitution: ignored null byte in input

I found the reason. Temporary workaround has been to clean the HTTP response as it included nullnullnullnull end of the string. See trick: https://github.com/halkyonio/primaza-poc/blob/main/scripts/common.sh#L138
According to @BarDweller, we should continue to investigate

"Verify the endpoint using postman, or another java client.. if those nulls are there, I'd raise an issue against primaza to get those fixed. if it's not primaza's quarkus code injecting the nulls, it might be quarkus itself, and that's a bug worth getting fixed."

@cmoulliard cmoulliard changed the title Bad substitution reported by primaza.sh script Bad substitution reported by primaza.sh script when HTTP body contains: nulnulnulnul Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants