Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related work: Prompt lookup decoding #45

Open
shermansiu opened this issue Jan 18, 2024 · 7 comments
Open

Related work: Prompt lookup decoding #45

shermansiu opened this issue Jan 18, 2024 · 7 comments

Comments

@shermansiu
Copy link

https://github.com/apoorvumang/prompt-lookup-decoding

This method was recently merged into Huggingface transformers and also uses n-grams (found in the input prompt) to accelerate decoding.

@learning-chip
Copy link

Interesting, could you point to the merged PR? Does it support batching?

This method has a similar idea (copy from input, no Jacobi): https://github.com/alipay/PainlessInferenceAcceleration

@shermansiu
Copy link
Author

Here's the PR: huggingface/transformers#27775

From a cursory glance at the PR, it seems like it supports batching.

@dongxiaolong
Copy link

Here's the PR: huggingface/transformers#27775

From a cursory glance at the PR, it seems like it supports batching.

I have also noticed these two methods.
Do you know the specific difference between them?

@shermansiu
Copy link
Author

Lookahead decoding takes the n-grams from prior lookahead decoding steps /Jacobi trajectories. Prompt lookup decoding takes the n-grams from the prompt.

@learning-chip
Copy link

it seems like it supports batching.

It doesn't :/ huggingface/transformers#27775 (comment)

@shermansiu
Copy link
Author

Interesting. As the comment also suggests, it seems like PLD can support batching in theory - it's just the implementation that doesn't support it.

@jivanph
Copy link

jivanph commented Jan 31, 2024

Lookahead was mentioned here https://github.com/SafeAILab/EAGLE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants