New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 2 support? #10

Open

guysoft opened this issue Feb 11, 2017 · 1 comment

guysoft commented Feb 11, 2017

Hey,
So I know its in the docs, but was wondering if there is a way to get Python 2 support?
What needs to be done to support python2?

plutec commented Jun 6, 2017

https://github.com/happyleavesaoc/python-orvibo/blob/master/orvibo/s20.py#L57
Replace by:
udp = threading.Thread(target=_listen) (daemon param is not allowed in Py2)

https://github.com/happyleavesaoc/python-orvibo/blob/master/orvibo/s20.py#L273
Replace by:
def _udp_transact(self, payload, handler, broadcast=False, timeout=TIMEOUT, *args):
Py2 only accepts possitional arguments at the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment