Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsphere_iso_location should be case-sensitive #452

Closed
dnv opened this issue Jul 15, 2024 · 2 comments
Closed

vsphere_iso_location should be case-sensitive #452

dnv opened this issue Jul 15, 2024 · 2 comments
Assignees

Comments

@dnv
Copy link

dnv commented Jul 15, 2024

I've just spent WAAAAY more time than I'd like to admit debugging a template build issue which was caused by the fact that while Packer behaves as if RHEL-8.10-x86_64-dvd.iso and rhel-8.10-x86_64-dvd.iso are the same exact thing:

==> vsphere-iso: Mounting ISO images...
2024/07/15 14:54:32 packer-plugin-vsphere_v1.3.0_x5.0_linux_amd64 plugin: 2024/07/15 14:54:32 Check if ISO path is a Content Library path
2024/07/15 14:54:32 packer-plugin-vsphere_v1.3.0_x5.0_linux_amd64 plugin: 2024/07/15 14:54:32 ISO path not identified as a Content Library path
2024/07/15 14:54:32 packer-plugin-vsphere_v1.3.0_x5.0_linux_amd64 plugin: 2024/07/15 14:54:32 Using [REDACTEDLUN] ISOandMediaFolder/RHEL-8.10-x86_64-dvd.iso as the datastore path
2024/07/15 14:54:32 packer-plugin-vsphere_v1.3.0_x5.0_linux_amd64 plugin: 2024/07/15 14:54:32 Creating CD-ROM on controller '&{{{} 200 0xc000a60c80 <nil> <nil> <nil> 0 <nil> 0 <nil>} 0 []}' with iso '[REDACTEDLUN] ISOandMediaFolder/RHEL-8.10-x86_64-dvd.iso'

the reality is that this will result in ESX hosts not seeing the ISO and the CD/DVD will be in Disconnected state and you will possibly spend way too much time chasing why your DHCP is suddenly broken (which will not be the DHCP the installer is trying to use, but rather the freshly created VM trying to boot off PXE since the CD/DVD device is disconnected).

@tenthirtyam
Copy link
Collaborator

tenthirtyam commented Jul 15, 2024

I think a more logical approach would be verify that the file name provided exists and fail early in the Prepare() if it's not a match to an existing file name in the datastore.

@tenthirtyam
Copy link
Collaborator

Superseded by #453.

@tenthirtyam tenthirtyam closed this as not planned Won't fix, can't repro, duplicate, stale Jul 15, 2024
@tenthirtyam tenthirtyam self-assigned this Jul 15, 2024
@hashicorp hashicorp locked and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants