Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subclasses of PSTableCell <PSHeaderFooterView> disappear on reload #53

Open
RedenticDev opened this issue Sep 25, 2021 · 0 comments
Open

Comments

@RedenticDev
Copy link
Contributor

I've noticed this issue playing with one of the subclasses I made, and the issue I have does in fact affect to every single subclass of PSTableCell <PSHeaderFooterView>. I've tried on my tweak, on Sonify, and even on Cephei Demo. I've detailed the issue here.

The issue is, when "reloading" the subclass, it disappears, and is in fact unlinked from its superview (its superview becomes nil). It's easily reproducible by calling beginUpdates then endUpdates on the table view containing the cell. It's solved by itself by scrolling out of the concerned PSGroupCell and back in, and my first guess is that it could be a view recycling-related issue.
I was not able to find any answer somewhere as it seems that nobody has ever encountered this issue, but it does exist.

I know it's not directly related to Cephei but some Cephei classes are affected (HBPackageNameHeaderCell & HBImageTableCell) and maybe we could work together on integrating a fix here to create sort of: PSTableCell <PSHeaderFooterView> > HBFixedHeaderFooterCell > {HBPackageNameHeaderCell, HBImageTableCell, MyCustomSubclass...}

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant