Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP media support JSON-B/P and Jackson configuration #9680

Open
Verdent opened this issue Jan 23, 2025 · 0 comments
Open

HTTP media support JSON-B/P and Jackson configuration #9680

Verdent opened this issue Jan 23, 2025 · 0 comments
Assignees
Labels
4.x Version 4.x bug Something isn't working media-support Media type processing in SE P2

Comments

@Verdent
Copy link
Member

Verdent commented Jan 23, 2025

It is currently not possible configure JSON-B/P instances used in HTTP media support in any way. Method accepting custom instance are missing completely. JacksonSupport do have create method, which accepts custom ObjectMapper. It should be aligned in all our media supports.

public static MediaSupport create(ObjectMapper objectMapper) {
return create(objectMapper, "jackson");
}

In addition to that, all of our previously mentioned media supports (including Jackson) are missing configuration from the config. Config is passed to the create method, but ignored and never processed. See

public static MediaSupport create(Config config, String name) {
Objects.requireNonNull(config);
Objects.requireNonNull(name);
return new JsonbSupport(name);
}

@Verdent Verdent added 4.x Version 4.x media-support Media type processing in SE labels Jan 23, 2025
@Verdent Verdent added this to Backlog Jan 23, 2025
@github-project-automation github-project-automation bot moved this to Triage in Backlog Jan 23, 2025
@Verdent Verdent added the bug Something isn't working label Jan 23, 2025
@m0mus m0mus added the P2 label Jan 30, 2025
@m0mus m0mus moved this from Triage to High priority in Backlog Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x bug Something isn't working media-support Media type processing in SE P2
Projects
Status: High priority
Development

No branches or pull requests

2 participants