feat: Streamline key and alias specifications for AccountCreateTransaction
#1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
…-for-AccountCreateTransaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New methods need to be added to the SDK in order to streamline account key specifications with considerations for alias.
The following APIs need to be added in
AccountCreateTransaction:setKeyWithAlias(ECDSAKey)- Sets ECDSA private key, derives and sets it's EVM address in the background. Essentially doessetKey(Key)+setAlias(Alias)setKeyWithAlias(Key, ECDSAKey)- Allows for setting the account key and a separate key that the EVM address should be derived from. A user must sign the transaction with both keys for this flow to be successful.setKeyWithoutAlias(Key)- Explicitly calls out that the alias is not set.The following APIs need to be deprecated in
AccountCreateTransaction:setKey(Key)Fixes: #1219