Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunk size #49

Open
hoelzer opened this issue Apr 6, 2023 · 1 comment
Open

Chunk size #49

hoelzer opened this issue Apr 6, 2023 · 1 comment

Comments

@hoelzer
Copy link
Contributor

hoelzer commented Apr 6, 2023

We have a new --chunk parameter to split the ILP corpus for faster parallel computing.

However, when the chunk size is too large concerning the number of input genomes, RIBAP crashes. E.g., I tried --chunks 80 for eight input genomes: crash.

We could add a check and warning. Or even better: we automatically adjust the chunk size when the user is defining something to high in comparison to the input genomes (not sure what would be a good formula here... e.g. --chunks 200 for 167 Klebsiella was fine, ...)

@klamkiew
Copy link
Collaborator

klamkiew commented Apr 7, 2023

I think the formula is number of pairwise comparisons == upper limit for --chunks
E.g., 8 input genomes lead to 28 pairwise comparisons, meaning it doesn't make sense to have more than 28 chunks.
Not sure how / when to tell NF this though ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants