Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hof/gen: better duplicate detection and error messages #234

Open
1 task
verdverm opened this issue Jun 14, 2023 · 0 comments
Open
1 task

hof/gen: better duplicate detection and error messages #234

verdverm opened this issue Jun 14, 2023 · 0 comments

Comments

@verdverm
Copy link
Member

verdverm commented Jun 14, 2023

While working on: afd5124

I noticed that the messaging when duplicates are found is inconsistent. We could add the logic in this commit to more places, and more similar logic for finding where duplicates come from.

I don't think this currently works across generators, output files really ought to be recorded at both the generator and runtime level, then we can query and detect cross-generator output duplication, maybe even find a way to merge them, especially for data files where the values can be merged at the CUE level before rendering it once for all generators (i.e. we'd lift this out into the runtime or a special generator for data file collision and merging?


  • ensure tests for the various conflict cases exist and pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant