Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README mentions option "list-commits-exceeding-patch-set-count" for gerrit_stats.sh but it does not seem to exist #79

Open
SylvainDe opened this issue Aug 30, 2023 · 0 comments

Comments

@SylvainDe
Copy link

As per the title, it looks to me like the option mentionned in the README does not exist anymore.

Also, using "git log -p -S list-commits-exceeding-patch-set-count", I stumbled upon a related commit b9a5ba7 :

commit b9a5ba74eb4900ce1984588ea58661e724b5b1c1
Author: Lasse Holmstedt <[email protected]>
Date:   Tue Aug 25 22:03:44 2015 +0200

    Create a chart of commits that exceed n patch sets
    
    Rename the command line argument to --commit-patch-set-count-threshold in
    preparation to always make the listing occur, with some default value set.

But even trying to use "commit-patch-set-count-threshold" did not quite work for me and it looks like this was deleted with 1b08f25 :

commit 1b08f250233eaa0d2c327a352961ac665633fa02
Author: Lasse Holmstedt <[email protected]>
Date:   Tue Sep 27 22:27:16 2016 -0700

    Add pmd to gradle check step
    
    The config file is from
    https://github.com/GoogleCloudPlatform/google-cloud-java
    with minor modifications, and licensed under Apache license.
    
    As with checkstyle, this can be run with:
    ./gradlew check
    ./gradlew clean check

I'm happy to submit a PR to update the doc if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant